Skip to content

export Notification from notification.type #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2017
Merged

Conversation

Caballerog
Copy link
Contributor

Export Notification from notification.type which is useful in typeScript return type for example:

method1(param1: string, param2: string): void | Notification {
   if(condition)
     return this.notificationService.error('ERROR', 'Summary');
   }
 }

@Caballerog
Copy link
Contributor Author

I don't know why travis-ci failed:

npm ERR! Linux 4.4.0-51-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v5.12.0/bin/node" "/home/travis/.nvm/versions/node/v5.12.0/bin/npm" "run" "test"
npm ERR! node v5.12.0
npm ERR! npm v3.8.6
npm ERR! code ELIFECYCLE
npm ERR! angular2-notifications@0.4.47 test: karma start
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the angular2-notifications@0.4.47 test script 'karma start'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-notifications package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! karma start
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs angular2-notifications
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls angular2-notifications
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /home/travis/build/flauc/angular2-notifications/npm-debug.log
The command "npm run test" exited with 1.

@flauc
Copy link
Owner

flauc commented Jan 15, 2017

Huh, I think that wasn't you. I must have been tinkering with travis right about when you pushed.
I'll merge now, thanks for the PR 👍

@flauc flauc merged commit a8d7862 into flauc:master Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants