fix(proxy): Prevent duplicate domains and restore vhost on failure#72
Merged
fix(proxy): Prevent duplicate domains and restore vhost on failure#72
Conversation
- Add duplicate domain+path validation in addDomain API endpoint - Add nginx warning tolerance (ssl_stapling warnings no longer fail) - Add location deduplication in config generator to prevent duplicate location "/" errors - Add vhost backup/restore on proxy setup failure instead of deletion - Add WriteVirtualHost and GetVirtualHost to NginxManager interface Fixes issue where adding domains would fail due to ssl_stapling warnings and corrupt vhost config by deleting it on failure. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review Summary✨ This pull request significantly enhances the robustness and reliability of the Nginx proxy configuration management within the agent. Key improvements include a new rollback mechanism for Nginx virtual host updates, preventing system outages from bad configurations. Additionally, the system now correctly handles duplicate domain definitions and 🚀 Key Improvements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where adding domains would fail due to ssl_stapling warnings and corrupt vhost config by deleting it on failure.