inputcapture: add support for persist_mode and restore_token #1186
+355
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
De-duplicate the two identical implementations.
For PERSIST_MODE_NONE xdp_session_persistence_generate_and_save_restore_token() sets our token and restore_data to NULL. Let's not try to add it to the results then.
This can be destructured in the caller if need be but for session checks we need the Response so we can close the Session
So far it was good enough to pretend we're creating a session, let's switch this over to a true session object on the bus that we can call Close() on.
Identical in use to the RemoteDesktop/ScreenCast versions, this allows us to continue a session without prompting for user interaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to the existing RemoteDesktop/ScreenCast persist modes, just this time for InputCapture. This allows an application to keep the permissions past things like screen savers activating and whatnot.
Keeping this as draft until we have the mutter side for real-world testing beyond the test suite. libportal obviously will need updates as well.
cc @jadahl