Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret portal never returns a token #781

Open
bilelmoussaoui opened this issue Apr 23, 2022 · 3 comments
Open

Secret portal never returns a token #781

bilelmoussaoui opened this issue Apr 23, 2022 · 3 comments
Labels
bug help wanted needs diagnosis Root cause of the issue needs to be diagnosed portal: secret Secrets portal

Comments

@bilelmoussaoui
Copy link
Member

bilelmoussaoui commented Apr 23, 2022

After trying to make use of the secret portal, it seems per the docs that it should be returning a token to be passed in future calls of the portal but. It never returns anything in the Request's response signal. Is that something not currently implemented?

Another thing (that should be easily fixable), the portal doesn't mention it can take a handle_token option for the request

@bilelmoussaoui
Copy link
Member Author

libsecret itself doesn't seems to make use of that at all, see https://gitlab.gnome.org/GNOME/libsecret/-/blob/master/libsecret/secret-file-backend.c. Maybe that is something that should be dropped from the documentation/code.

cc @ueno

@ueno
Copy link
Contributor

ueno commented Apr 24, 2022

IIRC, it is reserved for future use, so it could handle NBDE like deployment scenario.

@bilelmoussaoui
Copy link
Member Author

I suppose it should be marked as such from the docs side.

GeorgesStavracas pushed a commit that referenced this issue Jun 21, 2022
aleixpol pushed a commit to aleixpol/xdg-desktop-portal that referenced this issue Aug 31, 2022
@GeorgesStavracas GeorgesStavracas moved this to Needs Triage in Triage Oct 2, 2023
@GeorgesStavracas GeorgesStavracas added portal: secret Secrets portal help wanted needs diagnosis Root cause of the issue needs to be diagnosed labels Oct 11, 2023
@GeorgesStavracas GeorgesStavracas moved this from Needs Triage to Triaged in Triage Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted needs diagnosis Root cause of the issue needs to be diagnosed portal: secret Secrets portal
Projects
Status: Triaged
Development

No branches or pull requests

3 participants