Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add way to exclude cursor from screen capture stream #234

Closed
jadahl opened this issue Oct 10, 2018 · 3 comments
Closed

Add way to exclude cursor from screen capture stream #234

jadahl opened this issue Oct 10, 2018 · 3 comments

Comments

@jadahl
Copy link
Collaborator

jadahl commented Oct 10, 2018

Right now the screen capture (including remote desktop) includes the cursor. This is due to there not being a defined way to pass the cursor position and sprite as meta data in the PipeWire stream, as well as no defined way to communicate what the stream should include. This should be added, both to avoid unnecessary frames just for cursor movements, as well as communicating the exact cursor position for a frame.
@jadahl
Copy link
Collaborator Author

jadahl commented Oct 10, 2018

cc:ing @wtay for the PipeWire part.

@matthiasclasen
Copy link
Contributor

sounds good

@matthiasclasen
Copy link
Contributor

I think AvailableCursorModes in the ScreenCast portal covers this

agx pushed a commit to agx/xdg-desktop-portal that referenced this issue Dec 20, 2023
@AsciiWolf @matthiasclasen
Update Czech translation (flatpak#234)
59a3f17
daemory pushed a commit to dangxiwang/webrtc that referenced this issue Apr 19, 2024
Update patch set 5
9b64090 
Patch Set 5:

> Patch Set 5:
> 
> (3 comments)
> 
> Hi Tomas, thanks so much for the refactoring! The cl generally looks good. Sorry for two more questions I did realized before. Please help to explain a bit.
> 
> Jamie@, please check the comment in mouse_cursor_monitor_linux.cc#34. Tomas@ here helped to contribute screen capture function on Wayland. One fact is the mouse cursor capture is part of pipewire screen capture. As I recall, Remoting wants screen capture alone and will handle cursor by itself. So I'd like to know the how Remoting can work with this on Wayland. Please take a look.

The cursor is part of the stream as of now, but we have plans to add it as metadata to the PipeWire stream. I created flatpak/xdg-desktop-portal#234 to track the issue upstream.

Patch-set: 5
CC: Gerrit User 8044 <8044@58829da1-049c-39fb-b951-ebdcd0984767>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jadahl @matthiasclasen