Fix a bunch of memory leaks #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swick
force-pushed
the
mr/gvariant-leaks
branch
from
cff8fd8 to
213ce62
Compare
|
Looks good to me, but we need to rebase this to get ci to pass |
There is memory leakage that is proportional to amount of incoming dbus traffic. Analyzing valgrind logs points towards GVariant reference leaks from functions like validate_arg0_name(). Documentation for g_variant_get_child_value() states: "The returned value is never floating. You should free it with g_variant_unref() when you're done with it." Many functions omit such cleanup actions. Use g_autoptr(GVariant) type for variables that are used for storing g_variant_get_child_value() return value - like how it is already done in get_arg0_string(). Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
This also fixes a few cases where the message is no unreffed if the arguments are unexpected. Signed-off-by: Sebastian Wick <sebastian.wick@redhat.com>
GeorgesStavracas
force-pushed
the
mr/gvariant-leaks
branch
from
213ce62 to
3e27b5f
Compare
GeorgesStavracas
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a patch (#51 (comment)) by @spiiroin with an extra commit on top fixing a few more cases.