fix: Update flatpak-builder dependencies, fixes #214

[jochumdev]

This fixes issue #214 by updating dependencies of flatpak-builder.

Thanks for the great action!

Kind regards,
René

[Totto16]

Just a question, this repo never used webpack, since there is only one index.js, there is no need for a bundler, why did you add a webpack configuration? I think that never makes it past an eventual review 😓

[Totto16]

Please remove all webpack related stuff 😓

(Side note, I am not a member of this org, but since nobody reviewed this after 5 days, I just reviewed this PR, actual maintainers might have different opinions than me, but I'll say that my suggestions are at least sound by the practices of the rest of the repo)

[jochumdev]

Just a question, this repo never used webpack, since there is only one index.js, there is no need for a bundler, why did you add a webpack configuration? I think that never makes it past an eventual review 😓

I wasn't sure howto build that dist/index.js - so for the quick one i used webpack as everywhere in that file webpack was referenced (because of loaders ofc.).

Will remove that.

[jochumdev]

@Totto16 can you please build dist/index.js somehow and upload it to that branch?

[Totto16]

@Totto16 can you please build dist/index.js somehow and upload it to that branch?

After some deep dive I think you weren't that wrong with the webpack file, the generated dist/index.js file really looks like it was generated by webpack 😓 My bad for not catching that, as said I am no real maintainer of this repo 😓

I think you just can use the webpack config you used, install webpack and webpack-cli globally with e.g. npm i -g webpack webpack-cli and then just commit the changes of dist/index.js

[jochumdev]

I think you just can use the webpack config you used, install webpack and webpack-cli globally with e.g. npm i -g webpack webpack-cli and then just commit the changes of dist/index.js

What do you think about adding webpack back to the repo, so it's documented.

[Totto16]

I think you just can use the webpack config you used, install webpack and webpack-cli globally with e.g. npm i -g webpack webpack-cli and then just commit the changes of dist/index.js

What do you think about adding webpack back to the repo, so it's documented.

For that a real maintainer needs to explain, why it isn't present in the first place... I find that a good idea, but maybe do that in a separate PR, so that this just has the needed fixes and can be merged faster, and the discussion about this might take a while

[bilelmoussaoui]

Thanks for the review @Totto16.

Generating the dist file is described in https://github.com/flatpak/flatpak-github-actions/blob/master/CONTRIBUTING.md, if you want to switch to using something like webpack, please do that in a separate PR and use the described method above to re-generate the file for now.

Thanks!

[jochumdev]

@bilelmoussaoui

Do you want to fix the failing checks or should I?

Also can you please mention the CONTRIBUTING.md in the README?

[bilelmoussaoui]

Do you want to fix the failing checks or should I?

I can't tell what is going on from a quick look, it is completely unrelated to your changes but it would be nice to get it fixed to ensure everything is still working correctly.

Also can you please mention the CONTRIBUTING.md in the README?

Feel free to add it as a separate commit in this PR if you want to :)

[bilelmoussaoui]

Closing in favour of #217