Include ".flatpak" suffix in artifact name to avoid conflicts with other artifacts#177
Closed
darkdragon-001 wants to merge 1 commit intoflatpak:masterfrom
Closed
Include ".flatpak" suffix in artifact name to avoid conflicts with other artifacts#177darkdragon-001 wants to merge 1 commit intoflatpak:masterfrom
darkdragon-001 wants to merge 1 commit intoflatpak:masterfrom
Conversation
darkdragon-001
force-pushed
the
artifact-flatpak-suffix
branch
2 times, most recently
from
4a71646 to
4ee793f
Compare
darkdragon-001
changed the title
Author
|
@bilelmoussaoui friendly ping |
Member
|
The changes in the commit are not enough. Please see the contributing guidelines |
This is necessary as we remove the .flatpak suffix when adding the arch suffix
darkdragon-001
force-pushed
the
artifact-flatpak-suffix
branch
from
4ee793f to
52155f5
Compare
Author
|
@bilelmoussaoui Thanks, I updated the |
Author
|
@bilelmoussaoui Is anything else missing from my side? |
Author
|
@barthalion applied this at flathub-infra@5ca6311 |
Author
|
Added to flathub-infra@5ca6311 |
Member
|
Pulled in #224, thanks & sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary as we remove the
.flatpaksuffix when adding the arch suffix. In workflows where one also builds other artifacts this name might conflict otherwise and it is obvious for users that app-ARCH is supposed to contain Flatpak bundles.