Fix up docs link #39
Closed
Fix up docs link #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rh-atomic-bot delegate=cgwalters |
1 similar comment
|
@cgwalters: 🔑 Insufficient privileges: Collaborator required |
|
@alexlarsson Try doing the delegate again? |
|
@rh-atomic-bot delegate=cgwalters |
|
✌️ @cgwalters can now approve this pull request |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 27, 2017
Closes: #39 Approved by: cgwalters
|
💔 Test failed - status-papr |
cgwalters
reviewed
Sep 27, 2017
ci/build.sh
Outdated
| cd flatpak | ||
| unset CFLAGS # the sanitizers require calling apps be linked too | ||
| build | ||
| make |
There was a problem hiding this comment.
build already invokes make.
ci/build.sh
Outdated
| /usr/bin/{update-mime-database,update-desktop-database,gtk-update-icon-cache} | ||
| pkg_install_if_os fedora gjs parallel clang | ||
|
|
||
| # Temporarily build ostree from git master for https://github.com/flatpak/flatpak/pull/848 | ||
| (git clone --depth=1 https://github.com/ostreedev/ostree/ | ||
| # Use ostree minimal dependency |
There was a problem hiding this comment.
BTW see also projectatomic/papr#10
alexlarsson
force-pushed
the
test-homu
branch
2 times, most recently
from
8155236 to
693c671
Compare
|
bot, retest |
alexlarsson
force-pushed
the
test-homu
branch
from
693c671 to
fd0a1b9
Compare
These were reported by clang
alexlarsson
force-pushed
the
test-homu
branch
from
fd0a1b9 to
0d2755c
Compare
|
@cgwalters do you have any idea why this installs ostree 2017.10 when the same in e.g. flatpak/flatpak#1047 installes ostree 2017.11. Both enable updates-testing which should have the new ostree... |
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 28, 2017
These were reported by clang Closes: #39 Approved by: alexlarsson
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.