-
Notifications
You must be signed in to change notification settings - Fork 96
Add GameMode shared module #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Simplified it a bit, so now it handles everything in one manifest. |
Co-authored-by: Patrick <tingping@tingping.se>
|
By the way, for lutris we also do a 32bit build (is this needed like at all?), can that be done with this shared-module? |
I don't believe a 32-bit build is needed, but I could look into doing a 32-bit one as well. Though, it might be a bit weird, as apparently Lutris adds an ld flag and libdir.... TingPing might be able to give me some tips on that, if those are needed. https://github.com/flathub/net.lutris.Lutris/blob/beta/net.lutris.Lutris.yml#L70 |
|
A 32bit build would be needed. As a separate manifest. |
|
Could I have some tips? I don't know how I would go about adding the 32-bit variant, especially since it seems to need some modifications to the ldflags and whatnot. |
Lutris seems to do it via some flags, which seems very application specific |
|
Update comment: It seems like I can add 32-bit builds fairly easily, but it might be safer to separate them into their own manifest? I'll also stop versioning this when I get to updating it, for the same reasons I'll stop versioning the SDL2 module: there isn't much reason to it, since it's more or less compatible across versions. |
|
Was looking for this one. Any updates needed? This is what Steam does.... - name: gamemode
buildsystem: meson
config-opts:
- -Dwith-systemd=false
- -Dwith-daemon=false
- -Dwith-examples=false
sources:
- type: git
url: https://github.com/FeralInteractive/gamemode
commit: 76a6fb709f61f90d794ec5c12cc2896eb89aa811Should we be passing |
gamemode/gamemode-1.7.json
Outdated
| "cleanup": [ "/include", "/lib/pkgconfig" ], | ||
| "post-install": [ | ||
| "install -t /app/bin -Dm755 ../data/gamemoderun", | ||
| "rm /app/lib/libgamemodeauto.a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add /lib/*.a to cleanup instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add *.a like everywhere else.
I need to manage 32-bit builds somehow, and I'm not sure on how to do that. I also need to fix up the cleanup stuff :P
I believe so, yes. It's not really relevant for Flatpak. I'll get to this when I have a computer set up |
Co-authored-by: Rob Loach <robloach@gmail.com>
Co-authored-by: Rob Loach <robloach@gmail.com>
|
I'm still not sure how I should handle 32-bit builds, until that's figured out, this is blocked. |
Who can benefit from the 32bit build currently? |
Basically anybody Wine-based. |
|
I'll close this in favor of https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1641. |
Particularly useful for a number of apps on Flathub, such as Lutris, Steam, Bottles, and WarThunder.
I've separated the libraries and script so that apps can add the bare minimum of what they need.