Skip to content

Conversation

@orowith2os
Copy link
Contributor

Particularly useful for a number of apps on Flathub, such as Lutris, Steam, Bottles, and WarThunder.

I've separated the libraries and script so that apps can add the bare minimum of what they need.

@orowith2os orowith2os requested a review from a team as a code owner December 9, 2022 09:59
@orowith2os
Copy link
Contributor Author

Simplified it a bit, so now it handles everything in one manifest.

@orowith2os orowith2os requested a review from TingPing December 9, 2022 20:26
Co-authored-by: Patrick <tingping@tingping.se>
@A6GibKm
Copy link
Collaborator

A6GibKm commented Dec 10, 2022

By the way, for lutris we also do a 32bit build (is this needed like at all?), can that be done with this shared-module?

@orowith2os
Copy link
Contributor Author

By the way, for lutris we also do a 32bit build (is this needed like at all?), can that be done with this shared-module?

I don't believe a 32-bit build is needed, but I could look into doing a 32-bit one as well. Though, it might be a bit weird, as apparently Lutris adds an ld flag and libdir.... TingPing might be able to give me some tips on that, if those are needed.

https://github.com/flathub/net.lutris.Lutris/blob/beta/net.lutris.Lutris.yml#L70
https://github.com/flathub/net.lutris.Lutris/blob/beta/net.lutris.Lutris.yml#L283

@TingPing
Copy link
Member

A 32bit build would be needed. As a separate manifest.

@orowith2os
Copy link
Contributor Author

Could I have some tips? I don't know how I would go about adding the 32-bit variant, especially since it seems to need some modifications to the ldflags and whatnot.

@Doomsdayrs
Copy link

Could I have some tips? I don't know how I would go about adding the 32-bit variant, especially since it seems to need some modifications to the ldflags and whatnot.

Lutris seems to do it via some flags, which seems very application specific

@orowith2os
Copy link
Contributor Author

Update comment: It seems like I can add 32-bit builds fairly easily, but it might be safer to separate them into their own manifest?

I'll also stop versioning this when I get to updating it, for the same reasons I'll stop versioning the SDL2 module: there isn't much reason to it, since it's more or less compatible across versions.

@RobLoach
Copy link

RobLoach commented May 16, 2023

Was looking for this one. Any updates needed? This is what Steam does....

  - name: gamemode
    buildsystem: meson
    config-opts:
      - -Dwith-systemd=false
      - -Dwith-daemon=false
      - -Dwith-examples=false
    sources:
      - type: git
        url: https://github.com/FeralInteractive/gamemode
        commit: 76a6fb709f61f90d794ec5c12cc2896eb89aa811

Should we be passing with-systemd=false?

"cleanup": [ "/include", "/lib/pkgconfig" ],
"post-install": [
"install -t /app/bin -Dm755 ../data/gamemoderun",
"rm /app/lib/libgamemodeauto.a"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add /lib/*.a to cleanup instead

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add *.a like everywhere else.

@orowith2os
Copy link
Contributor Author

orowith2os commented May 16, 2023

Any updates needed?

I need to manage 32-bit builds somehow, and I'm not sure on how to do that. I also need to fix up the cleanup stuff :P

Should we be passing with-systemd=false?

I believe so, yes. It's not really relevant for Flatpak.

I'll get to this when I have a computer set up

@orowith2os orowith2os mentioned this pull request Jun 7, 2023
Co-authored-by: Rob Loach <robloach@gmail.com>
Co-authored-by: Rob Loach <robloach@gmail.com>
@orowith2os
Copy link
Contributor Author

I'm still not sure how I should handle 32-bit builds, until that's figured out, this is blocked.

@Doomsdayrs
Copy link

I'm still not sure how I should handle 32-bit builds, until that's figured out, this is blocked.

Who can benefit from the 32bit build currently?

@orowith2os
Copy link
Contributor Author

Who can benefit from the 32bit build currently?

Basically anybody Wine-based.

@orowith2os
Copy link
Contributor Author

I'll close this in favor of https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1641.

@orowith2os orowith2os closed this Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants