Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop org.kde.* own-name #55

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Sep 28, 2023

This is no longer required with any supported runtimes

https://docs.flatpak.org/en/latest/desktop-integration.html#statusnotifier

Most implementations of StatusNotifer have dropped this requirement

flathub-infra/flatpak-builder-lint#66

This is no longer required with any supported runtimes

https://docs.flatpak.org/en/latest/desktop-integration.html#statusnotifier

> Most implementations of StatusNotifer have dropped this requirement

flathub-infra/flatpak-builder-lint#66
@flathubbot
Copy link
Contributor

Started test build 69351

@flathubbot
Copy link
Contributor

Build 69351 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52005/org.cryptomator.Cryptomator.flatpakref

@overheadhunter
Copy link
Collaborator

can we get a review from @purejava? 😉

@purejava
Copy link
Contributor

can we get a review from @purejava? 😉

Sure! 😃
I tested build 69351 on KUbuntu 23.04, and it works without problems.
For testing purposes, I created two vaults and used the tray menu to show the settings and manage the two vaults. The tray menu worked and reflected the changes of the vault statuses.

From my point of view, this PR can be merged.

@overheadhunter overheadhunter merged commit 7c97514 into flathub:master Sep 28, 2023
@bbhtt bbhtt deleted the drop-kde-own-name branch September 28, 2023 13:13
@overheadhunter
Copy link
Collaborator

Thanks you for noticing and fixing this, @bbhtt 🙌

@bbhtt
Copy link
Contributor Author

bbhtt commented Sep 28, 2023

No problem, in the future this will be moved to an error in the linter https://github.com/flathub/flatpak-builder-lint/pull/ 114, so I'm cleaning up apps using it.

Giving access to entire org.kde.* bus is a risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants