Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict default filesystem access to ~/.MakeMKV and ~/Videos #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joshua-stone
Copy link

Qt can use the file picker portal to gain write access to specific directories from within the sandbox.

This seems to work for scenarios like:

  • setting alternative data directories
  • writing files to external drives

@flathubbot
Copy link
Contributor

Started test build 83180

@flathubbot
Copy link
Contributor

Build 83180 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65815/com.makemkv.MakeMKV.flatpakref

@joshua-stone
Copy link
Author

joshua-stone commented Nov 23, 2023

Filesystem access can be tested by setting a data directory through the file picker:

$ flatpak run --nofilesystem=home --filesystem='~/.MakeMKV:create' com.makemkv.MakeMKV

image

Then run find on the directory:

$ flatpak run --nofilesystem=home --filesystem='~/.MakeMKV:create' --command=sh com.makemkv.MakeMKV -c 'grep app_DataDir ~/.MakeMKV/settings.conf | cut -f2 -d \" | xargs find'
/run/user/1000/doc/7a8a5adb/.MakeMKV.test
/run/user/1000/doc/7a8a5adb/.MakeMKV.test/_private_data.tar

Qt can use the file picker portal to gain write access to specific
directories from within the sandbox.
@flathubbot
Copy link
Contributor

Started test build 83597

@joshua-stone joshua-stone changed the title Restrict default filesystem access to ~/.MakeMKV Restrict default filesystem access to ~/.MakeMKV and ~/Videos Nov 25, 2023
@flathubbot
Copy link
Contributor

Build 83597 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66230/com.makemkv.MakeMKV.flatpakref

@nalsai
Copy link

nalsai commented Jun 24, 2024

Wouldn't persist instead of filesystem be better for ~/.MakeMKV, or is there a reason it needs filesystem?

@flathubbot
Copy link
Contributor

Started test build 130227

@flathubbot
Copy link
Contributor

Build 130227 failed

@albertescanes
Copy link

Access to just xdg-videos and a persistent for ~/.MakeMKV sounds very good to me as well. Any chance we can get this merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants