Drop org.kde.* own-name #318
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started test build 69303 |
|
Build 69303 successful |
|
This seems to need loggin in. I don't have an account, so testing needed. |
|
I tested this (or rather, the equivalent using Flatseal) and the tray icon does not appear. |
|
Ok thanks. I'll check tomorrow |
This is no longer required with any supported runtimes, the issue was fixed in Qt https://docs.flatpak.org/en/latest/desktop-integration.html#statusnotifier > Most implementations of StatusNotifer have dropped this requirement flathub-infra/flatpak-builder-lint#66 (comment)
wjt
force-pushed
the
drop-kde-own-name
branch
from
04c5f65 to
d582743
Compare
|
Started test build 77600 |
|
Build 77600 successful |
|
They are using a super old Qt version, 5.5.1 (compiled with GCC 4.8.4 on Ubuntu 14.04). The fix that enables to drop this permission is in Qt 5.15 LTS (only in KDE's patchsets) and Qt 6 (upstream). |
bbhtt
added a commit
to bbhtt/flatpak-builder-lint
that referenced
this pull request
Jan 17, 2024
requires --own-name='org.kde.*' under flatpak Only handles maintained applications that had activity in the past year Zoom: flathub/us.zoom.Zoom#416 Discord: flathub/com.discordapp.Discord#324 DiscordCanary: flathub/com.discordapp.DiscordCanary#78 Celeste: flathub/com.hunterwittenborn.Celeste#35 Tribler: flathub/org.tribler.Tribler#10 Dropbox: flathub/com.dropbox.Client#318
barthalion
pushed a commit
to flathub-infra/flatpak-builder-lint
that referenced
this pull request
Jan 23, 2024
requires --own-name='org.kde.*' under flatpak Only handles maintained applications that had activity in the past year Zoom: flathub/us.zoom.Zoom#416 Discord: flathub/com.discordapp.Discord#324 DiscordCanary: flathub/com.discordapp.DiscordCanary#78 Celeste: flathub/com.hunterwittenborn.Celeste#35 Tribler: flathub/org.tribler.Tribler#10 Dropbox: flathub/com.dropbox.Client#318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer required with any supported runtimes, the issue was fixed in Qt
https://docs.flatpak.org/en/latest/desktop-integration.html#statusnotifier
flathub-infra/flatpak-builder-lint#66 (comment)
Fixes #111