Open
Conversation
pothos
reviewed
Aug 25, 2020
vbatts
force-pushed
the
vbatts/codenames
branch
from
17defbc to
db5d07b
Compare
vbatts
changed the title
Member
Author
|
Since we're considering that CODENAME for LTS will be suitable, then perhaps it's not time to remove this, but instead update the codename and make it release configurable. |
Member
Author
|
putting this as a draft, until we agree on the name. |
This keeps the codename Oklo, and sets the stage for this variable to not be buried in this shell script. Instead providing it through the `manifest/version.txt` as `FLATCAR_VERSION_CODENAME`. If that value is present in the version.txt, then it will now clobber this burried `OS_CODENAME`. Signed-off-by: Vincent Batts <vbatts@kinvolk.io>
vbatts
force-pushed
the
vbatts/codenames
branch
from
db5d07b to
0b93f60
Compare
vbatts
changed the title
chewi
added a commit
that referenced
this pull request
Feb 23, 2026
It was never updated in a meaningful way. It was only used directly in lsb_release, which is a dead standard. It was included in the os-release `PRETTY_NAME` but not as a field on its own. Closes: #88 Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
added a commit
that referenced
this pull request
Feb 23, 2026
It was never updated in a meaningful way. It was only used directly in lsb_release, which is a dead standard. It was included in the os-release `PRETTY_NAME` but not as a field on its own. Closes: #88 Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.