Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop eclass tests, move obsolete eclasses to overlay #2248

Closed
wants to merge 4 commits into from

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Aug 20, 2024

We weren't syncing the eclass tests for ages and we weren't running them, so their existence in portage-stable is pointless at the moment. Also, three eclasses were removed from Gentoo, so we move them to our overlay as there is still a package or two that are using them.

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1682/cldsv/

We weren't syncing that for ages and we are not running those tests,
so drop the directory altogether.
They were removed from Gentoo. We still have users of those in
overlay, though.
@krnowak krnowak added the main label Aug 20, 2024
@krnowak krnowak marked this pull request as ready for review August 21, 2024 09:33
@krnowak krnowak requested a review from a team August 21, 2024 09:33
@krnowak
Copy link
Member Author

krnowak commented Aug 21, 2024

CI passed (I didn't run any tests - no package has changed, so I was only checking if stuff still builds.)

Copy link

github-actions bot commented Aug 21, 2024

Build action triggered: https://github.com/flatcar/scripts/actions/runs/10512648558

@chewi
Copy link
Contributor

chewi commented Aug 21, 2024

epatch is only used in one place and you simply need to replace the command with eapply.

@chewi
Copy link
Contributor

chewi commented Aug 21, 2024

epatch is only used in one place and you simply need to replace the command with eapply.

Okay, I see it is inherited by eutils. You could just remove that entry though.

@chewi
Copy link
Contributor

chewi commented Aug 21, 2024

To be honest, I'd rather just drop the few remaining instances of EAPI 6. Gentoo has literally just purged almost all of them this week. It won't take me long at all.

@krnowak
Copy link
Member Author

krnowak commented Aug 21, 2024

To be honest, I'd rather just drop the few remaining instances of EAPI 6. Gentoo has literally just purged almost all of them this week. It won't take me long at all.

That's obviously I'd like to eventually do. I think that the only Gentoo-derivative user of these eclasses in our overlay is sys-boot/syslinux. I think I tried updating the package or moving it to portage-stable long time ago, but there was something with newer version that broke our stuff, so I put that on hold and eventually forgot. Sorry for being vague, but yeah, it was long time ago (over 2 years ago, I think). There are other packages with EAPI 6 in overlay (git grep EAPI=.*6 will show them), but they should be trivial to handle.

For now I wanted to just move the obsolete eclasses, so that nothing breaks and the github automation will stop complaining about them being missing in Gentoo.

@chewi
Copy link
Contributor

chewi commented Aug 22, 2024

As discussed elsewhere, I have dropped all instances of EAPI 6, so we can just remove these eclasses now. I will open a new PR to succeed this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants