Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nmap netcat with openbsd netcat #2079

Merged
merged 11 commits into from
Aug 9, 2024
Merged

Replace nmap netcat with openbsd netcat #2079

merged 11 commits into from
Aug 9, 2024

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Jul 1, 2024

This PR replaces net-analyzer/nmap with net-analyzer/openbsd-netcat. It also installs the ncat symlink for compatibility.

Fixes flatcar/Flatcar#1460

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/4414/cldsv/

There are the following PRs in mantle and init that this PR is pulling in:

--

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@tormath1
Copy link
Contributor

tormath1 commented Jul 2, 2024

Unfortunately I think this might break the flatcar-update script for now: https://github.com/flatcar/init/blob/ed0ce5ab08d77ff8fa775975961987ae2704fb34/bin/flatcar-update#L272

Copy link

github-actions bot commented Jul 2, 2024

Build action triggered: https://github.com/flatcar/scripts/actions/runs/10261227317

@krnowak
Copy link
Member Author

krnowak commented Jul 2, 2024

Unfortunately I think this might break the flatcar-update script for now: https://github.com/flatcar/init/blob/ed0ce5ab08d77ff8fa775975961987ae2704fb34/bin/flatcar-update#L272

Well spotted. Thanks! There is also a kola test that uses ncat (docker.network I think), so it will also need an update.

@krnowak
Copy link
Member Author

krnowak commented Aug 6, 2024

CI passed.

@krnowak krnowak marked this pull request as ready for review August 6, 2024 06:11
@krnowak krnowak requested a review from a team August 6, 2024 06:11
@krnowak krnowak merged commit db9fa0f into main Aug 9, 2024
1 check failed
@krnowak krnowak deleted the krnowak/drop-nmap branch August 9, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[RFE] retiring nmap and creating a nmap system extension
4 participants