plume: update GCS URL to bincache URL #371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plume: remove BasePrivateURL
it's no more used.
plume/release: update GCS URL to bincache URL
I was expecting more complexity to update this URL but it seems that
storage
is able to understand both type of URL, it converts GCS URL to plain HTTP url:https://github.com/flatcar-linux/mantle/blob/fb7bbf6e2c863c0bcfb9dcba4c090e45eb8c4742/cmd/plume/containerlinux.go#L326-L328
Related issue: flatcar/Flatcar#838