Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facebook_js contrib #161

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

facebook_js contrib #161

wants to merge 27 commits into from

Conversation

rosscdh
Copy link

@rosscdh rosscdh commented Jul 19, 2012

Hey there,

Firstly thanks for your work on this great app.

I found that I needed the facebook-js-sdk for one of my products and am working on a version that removes the dependency on the facebook python sdk (being depreciated by facebook from what I understand) and replaces it (at least the basic login/signup functionality atm) with the facebook js sdk.

Its still quite rough; but I'd like your feedback on its direction anyway :)

Best regards
Ross

@flashingpumpkin
Copy link
Owner

Hi

Heh, funny. One of the reasons for the version jump and partial rewrite from v0.4 to v0.5 was getting rid of the JS SDK as there was not really a convenient way to test it (and it used to break in practice quite often or just display empty popups). Unfortunately - Facebook shortly afterwards killed the Python SDK. I've wanted to cut it out and replace it with requests for a while now but just have not had any time to do so.

I did find though that you can use the JS SDK with socialreg when doing the server side auth flow. You exchange the tokens on your site via AJAX once authenticated (or embed them in the site [caution - HTTPS!]) and then script away.

I do like that you went down the route of creating contrib.facebook_js though instead of cutting into contrib.facebook. There are a couple of quirky things in the code that I'll comment on when I get another second to look at it.

@rosscdh
Copy link
Author

rosscdh commented Jul 20, 2012

Hey there Alen,

Thanks for the reply and the history! I had a feeling it would have been
related to the facebook hop/skip/jump process; but in the end its all good!

I look forward to your comments, I'm more than happy to take them on board
as of course its your product :) Just please bear in mind thats its def a
work in progress with a view to merging down the track when it becomes more
"production" ready :)

I was thinking about making the Javascript Callbacks configurable (via
settings) so that the user could write their callbacks in their js and
simply have SR whack them back on the system events.

And probably would also, be a good idea to write an abstraction for all of
the FB subscribe events... but thats something i'll work on as we need it.

Best regards
Ross Crawford-d'Heureuse

On Fri, Jul 20, 2012 at 11:59 AM, Alen Mujezinovic <
reply@reply.github.com

wrote:

Hi

Heh, funny. One of the reasons for the version jump and partial rewrite
from v0.4 to v0.5 was getting rid of the JS SDK as there was not really a
convenient way to test it. Unfortunately - Facebook shortly afterwards
killed declared the Python SDK deprecated and I've wanted to cut it out and
replace it with requests for a while now but just have not had any time
to do.

I did find though that you can use the JS SDK with socialreg when doing
the server side auth flow. You just exchange the tokens on your site via
AJAX once authenticated (or embed them in the site [caution - HTTPS!]) and
then script away.

I do like that you went down the route of creating contrib.facebook_js
though instead of cutting into contrib.facebook. There are a couple of
quirky things in the code that I'll comment on when I get another second to
look at it.


Reply to this email directly or view it on GitHub:

#161 (comment)

@travisbot
Copy link

This pull request passes (merged 2c63084 into e2b5de3).

@travisbot
Copy link

This pull request passes (merged 4b597c0 into e2b5de3).

@travisbot
Copy link

This pull request passes (merged c070851 into e2b5de3).

@travisbot
Copy link

This pull request passes (merged 8de6640 into e2b5de3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants