[rose] Fix the computation of total_num_tiles_q
#652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzh119
approved these changes
Dec 10, 2024
yzh119
reviewed
Dec 10, 2024
nandor
force-pushed
the
nandor/fix-num-tiles-q
branch
from
2d93494 to
87c182c
Compare
The previous upper bound forgot to multiply with `gqa_group_size`.
nandor
force-pushed
the
nandor/fix-num-tiles-q
branch
from
87c182c to
4cb2d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous upper bound forgot to multiply with
gqa_group_size.