Skip to content

misc: typing improvement #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

misc: typing improvement #555

merged 1 commit into from
Oct 25, 2024

Conversation

@abcdabcd987
Copy link
Member

@abcdabcd987 abcdabcd987 commented Oct 25, 2024 •
edited
Loading

  1. Make mypy happy
  2. Adopt the from .x import y as y idiom of re-exporting things in __init__.py. See PEP 484
$ cd python/
$ mypy flashinfer/
Success: no issues found in 27 source files

@abcdabcd987 abcdabcd987 requested a review from yzh119 October 25, 2024 00:12
@yzh119 yzh119 changed the title typing improvement misc: typing improvement Oct 25, 2024
@yzh119 yzh119 merged commit 9e10936 into flashinfer-ai:main Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yzh119 yzh119 yzh119 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abcdabcd987 @yzh119