[CMake][Bugfix] Set default value for FLASHINFER_GEN_MASK_MODES #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves a build-time error with the following message: ``` CMake Error at 3rdparty/flashinfer/CMakeLists.txt:313 (add_library): No SOURCES given to target: prefill_kernels ``` This occurred after flashinfer-ai#266, which replaces the `FLASHINFER_GEN_CASUALS` option with `FLASHINFER_GEN_MASK_MODES`. However, the definition of `flashinfer_option(FLASHINFER_GEN_CASUALS ... )` was not replaced. As a result, loop over the empty `MASK_MODES` does not produce any kernels that should be compiled. This commit updates the `flashinfer_option(FLASH_GEN_CASUALS ...)` line to instead define `FLASH_GEN_MASK_MODES`, using the same default value as `config.cmake`.
Lunderberg
force-pushed
the
cmake_bugfix_default_mask_modes
branch
from
51f1afa to
9e7b8b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves a build-time error with the following message:
This occurred after #266, which replaces the
FLASHINFER_GEN_CASUALSoption withFLASHINFER_GEN_MASK_MODES. However, the definition offlashinfer_option(FLASHINFER_GEN_CASUALS ... )was not replaced. As a result, loop over the emptyMASK_MODESdoes not produce any kernels that should be compiled.This commit updates the
flashinfer_option(FLASH_GEN_CASUALS ...)line to instead defineFLASH_GEN_MASK_MODES, using the same default value asconfig.cmake.