install: remove nvidia-cudnn-12 from package dependency #1409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Description
The dependency is not required because:
nvidia-cudnn-12
is already a torch dependency (https://github.com/pytorch/pytorch/blob/3f1636ebef9b45e8a3cb0eb20d327ee6acb74be0/.github/scripts/generate_binary_build_matrix.py#L44-L95), and flashinfer depends on torch, there is no need to specify anothernvidia-cudnn-12
dependency in flashinfer.nvidia-cudnn-12
is not a torch dependency (like in nvidia's pytorch container), cudnn is installed at system wide and cudnn-frontend will rely on cudnn system installation instead of throughnvidia-cudnn-12
.🔍 Related Issues
nvidia-nvshmem-12
package is a similar redundant dependency: #1388🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commit
by runningpip install pre-commit
(or used your preferred method).pre-commit install
.pre-commit run --all-files
and fixed any reported issues.🧪 Tests
unittest
, etc.).Reviewer Notes