Skip to content

Conversation

@prestwich
Copy link

@prestwich prestwich commented Dec 19, 2025

📝 Summary

Based on #842. Draft until #842 is merged

Improves and corrects documentation in the live_builder, particularly around Order propagation through the OrderPool. Functionality does not change. Most significant API change is around BlobTypeOrderFilter, by moving constructors from free functions to assoc functions

  • Improve and correct OrderPool documentation
  • Add Copy impl for ReplacementData<KeyType>
  • Add missing Copy impl for NonceKey
  • make implementation of BlobTypeOrderFilter construction idiomatic for Rust
  • add missing trace! event to BlobTypeOrderFilter when filtering an order
  • add rule_name to BlobTypeOrderFilter to ensure behavior is clear in tracing event
  • add From impls for ReplaceableOrderEvent, and remove some relevant .clone invocations
  • update AutoRemovingOrderPoolSubscriptionId to use Weak to prevent them from holding OrderPool memory alloc for dying subscriptions
  • use FuturesUnordered instead of Vec<JoinHandle<()>> in the order pool to ensure parallelization of handle reaping

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant