Skip to content

Conversation

efbig
Copy link
Collaborator

@efbig efbig commented Sep 22, 2025

πŸ“ Summary

Add types for optimistic V3.

βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@metachris metachris requested a review from Copilot September 22, 2025 14:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds types for optimistic V3 bidding to support an enhanced MEV-boost protocol version. The changes refactor the module structure to separate block submission from header submission functionality and introduce new types for optimistic V3 operations.

  • Refactors MEV-boost module structure by renaming submission to block_submission and adding header_submission module
  • Adds complete optimistic V3 type definitions including signed payload requests and verification functions
  • Introduces bid adjustment data V2 with additional fields for SSZ merkle proofs and logs bloom

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
crates/rbuilder/src/mev_boost/optimistic_v3.rs New module defining optimistic V3 types and verification functions
crates/rbuilder/src/mev_boost/header_submission.rs New module with header submission types for optimistic V3
crates/rbuilder/src/mev_boost/adjustment.rs Adds BidAdjustmentDataV2 with new fields for optimistic V3
crates/rbuilder/src/mev_boost/mod.rs Updates module structure and imports for refactored submission modules
Multiple files Updates import paths from submission to block_submission

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@efbig efbig force-pushed the efbig/optimistic-v3-types branch from d78c18a to aac3747 Compare September 24, 2025 06:53
@efbig efbig force-pushed the efbig/optimistic-v3-types branch from aac3747 to eccfdb5 Compare September 24, 2025 07:05
@efbig efbig merged commit 6064832 into develop Sep 24, 2025
3 checks passed
@efbig efbig deleted the efbig/optimistic-v3-types branch September 24, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants