Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The whole pipeline has been updated to use
BlockBid
(all bids seen in all relays) insteadCompetitionBid
(single best bid to beat).This change gives more information to the bidding service and implies that the
SlotBidder
is now just aUnfinishedBlockBuildingSink
and theBiddingService
gets all the bids by implemeningBlockBidWithStatsObs
and is his responsibility to let the active bidders know about the competition bids.
The rbuilder now connects to the bid-scraper to get those
BlockBid
.Some other changes:
💡 Motivation and Context
Get rid of any external dependency to get competition bids.
✅ I have completed the following steps:
make lint
make test