Skip to content

New competition bid source. #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Conversation

ZanCorDX
Copy link
Collaborator

@ZanCorDX ZanCorDX commented Jul 2, 2025

📝 Summary

The whole pipeline has been updated to use BlockBid (all bids seen in all relays) instead CompetitionBid (single best bid to beat).
This change gives more information to the bidding service and implies that the SlotBidder is now just a UnfinishedBlockBuildingSink and the BiddingService gets all the bids by implemening BlockBidWithStatsObs

pub trait BlockBidWithStatsObs: Send + Sync {
    /// Be careful, we don't assume any kind of filtering here so bid may contain our own bids.
    fn update_new_bid(&self, bid_with_stats: BlockBidWithStats);
}

and is his responsibility to let the active bidders know about the competition bids.
The rbuilder now connects to the bid-scraper to get those BlockBid.
Some other changes:

  • ethers replaced by allow
  • Some refactoring on crates/rbuilder/src/live_builder/config.rs to simplify the creation of other cfgs.
  • Some lint cleaning.

💡 Motivation and Context

Get rid of any external dependency to get competition bids.

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@ZanCorDX ZanCorDX marked this pull request as ready for review July 2, 2025 21:01
@ZanCorDX ZanCorDX requested a review from dvush as a code owner July 2, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant