Use latest reth for op-rbuilder #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
changed the title
avalonche
requested review from
dvush,
ZanCorDX,
ferranbt and
metachris
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the op-rbuilder to use the latest reth dependencies and features, with changes across several modules to align with new reth versions and improve functionality. Key changes include:
- Combined and cleaned up flashblocks imports in the tester module.
- Added a new optional requests_hash field in the ExecutedPayload structure and updated related logic in the payload builder.
- Adjusted gas estimation logic and updated dependency versions in Cargo.toml.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/op-rbuilder/src/tester/mod.rs | Consolidated flashblocks imports and removed redundant commented code. |
| crates/op-rbuilder/src/primitives/reth/execution.rs | Added requests_hash field to the ExecutedPayload struct. |
| crates/op-rbuilder/src/payload_builder_vanilla.rs | Updated gas estimation calculation and adjusted tuple creation for withdrawals and requests. |
| crates/op-rbuilder/src/main.rs | Updated sequencer reference to match new API naming. |
| Cargo.toml | Upgraded reth-related dependencies to v1.3.12 and adjusted compatibility comments. |
Cargo.toml
Outdated
|
|
||
| # compatible with reth "v1.3.11" dependencies | ||
| # compatible with reth "v1.3.9" dependencies |
There was a problem hiding this comment.
The compatibility comment still refers to reth v1.3.9 while the dependencies have been updated to v1.3.12; please update the comment to reflect the current dependency version.
Suggested change
| # compatible with reth "v1.3.9" dependencies | |
| # compatible with reth "v1.3.12" dependencies |
Copilot uses AI. Check for mistakes.
ZanCorDX
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test