Add txn monitoring in op-rbuilder pool #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
reviewed
Mar 13, 2025
crates/op-rbuilder/src/args.rs
Outdated
| @@ -38,4 +38,8 @@ pub struct OpRbuilderArgs { | |||
| env = "FLASHBLOCK_BLOCK_TIME" | |||
| )] | |||
| pub flashblock_block_time: u64, | |||
|
|
|||
| /// Signals whether to log pool transactions events | |||
| #[arg(long = "log-pool-transactions", default_value = "false")] | |||
There was a problem hiding this comment.
non blocking: we should rename the args to the builder namespace
avalonche
reviewed
Mar 13, 2025
| fn transaction_event_log(event: FullTransactionEvent<OpPooledTransaction>) { | ||
| match event { | ||
| FullTransactionEvent::Pending(hash) => { | ||
| debug!("Transaction event: tx={:?}, kind=pending", hash) |
There was a problem hiding this comment.
this wouldn't work with json structured logging?
Suggested change
| debug!("Transaction event: tx={:?}, kind=pending", hash) | |
| debug!( | |
| tx_hash=tx_hash.to_string(), | |
| kind = "pending", | |
| "Transaction event received" | |
| ) |
There was a problem hiding this comment.
I will change this once I am back at home
avalonche
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR introduces a monitoring service that prints all the transactions that arrive to the transaction pool in op-rbuilder.
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test