fix: record missing flashblocks #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akundaz
requested review from
ferranbt,
SozinM,
avalonche and
karim-agha
as code owners
akundaz
force-pushed
the
ak-record-missing-flashblocks
branch
from
5ab320e to
a36aa21
Compare
SozinM
approved these changes
Aug 6, 2025
avalonche
reviewed
Aug 6, 2025
| target: "payload_builder", | ||
| message = message, | ||
| missing_flashblocks = flashblocks_per_block.saturating_sub(ctx.flashblock_index()), | ||
| reduced_flashblocks = self.config.flashblocks_per_block().saturating_sub(flashblocks_per_block), |
There was a problem hiding this comment.
instead of the number of missing flashblocks I would have the raw values e.g. flashblocks_per_block, flashblock_index and flashblocks per block as the flashblocks_per_block and ctx.flashblock_index() values can potentially change for every block
There was a problem hiding this comment.
Sure, there are two flashblocks_per_block values though so I named one of them config_flashblocks_per_block. Is there a better name for that?
SozinM
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Record how many flashblocks we missed
💡 Motivation and Context
We're not recording this metric properly at the moment
✅ I have completed the following steps:
make lintmake test