Bundles: Ensure that the min block number is inside the MAX_BLOCK_RANGE_BLOCKS #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GE_BLOCKS If a user only specifies the min block number, the max block number is set to the current block number + MAX_BLOCK_RANGE_BLOCKS; however, there is no check that the min block is less than the newly set max block number.
trianglesphere
requested review from
ferranbt,
SozinM,
avalonche and
karim-agha
as code owners
avalonche
reviewed
Jun 6, 2025
| if let Some(block_number_min) = bundle.block_number_min { | ||
| if block_number_min > bundle.block_number_max.unwrap() { | ||
| return Err( | ||
| EthApiError::InvalidParams("block_number_min is too high".into()).into(), |
There was a problem hiding this comment.
it would be helpful to return the block_number_min and block_number_max in the error message
ferranbt
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user only specifies the min block number, the max block number is set to the current block number + MAX_BLOCK_RANGE_BLOCKS; however, there is no check that the min block is less than the newly set max block number.