Upgrade to reth 1.4.7 and main rollup-boost branch #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karim-agha
approved these changes
Jun 4, 2025
SozinM
reviewed
Jun 4, 2025
| @@ -664,7 +664,7 @@ where | |||
| block_hash, | |||
| transactions: new_transactions_encoded, | |||
| withdrawals: ctx.withdrawals().cloned().unwrap_or_default().to_vec(), | |||
| withdrawals_root, | |||
There was a problem hiding this comment.
I don't think there is correct default for this
Probably better to just expect, because it would mean that we don't support pre-isthmus chains
SozinM
reviewed
Jun 4, 2025
| @@ -2,6 +2,7 @@ use super::DEFAULT_JWT_TOKEN; | |||
| use alloy_eips::{eip7685::Requests, BlockNumberOrTag}; | |||
| use alloy_primitives::B256; | |||
| use alloy_rpc_types_engine::{ForkchoiceUpdated, PayloadStatus}; | |||
| use http::Uri; | |||
There was a problem hiding this comment.
Have they break compatibility with uri::Uri?
Can you do .to_string for uri::Uri?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
upgrade reth to 1.4.7.
💡 Motivation and Context
bug fixes and compatibility with the latest rollup-boost
✅ I have completed the following steps:
make lintmake test