Classifiers: add 1inch Limit Order Protocol #91
Conversation
|
I cannot use the Infura rpc to test this. Which RPC do you use? |
@ElOpio It requires an archive node, sending you a link on discord |
|
Thanks a lot @taarushv! <3 I've been debugging this, and it is blocked because there is a bug when we get the selector of a function that has a tuple. I'm having a lot of fun digging into this :) |
come-maiz
force-pushed
the
classifier/1inch
branch
2 times, most recently
from
0909746
to
215f869
Compare
|
I've pushed #94 to fix the tuple issues. Now I'm confused about classifying this as a swap, because it seems to requiere a pool: In this protocol, the swap is direct from an open order. I'm not sure what to do about the pool. Is it that this is not a swap, or is it that pools in swaps should be optional? 🤔 Who can help me finishing this branch? |
|
@ElOpio I can help you get this over the line which approach do you prefer? happy to talk through in discord as well |
|
Thank you @lukevs. Let's try to do it here. My main question is if this, in order to be a swap, needs a pool. |
come-maiz
force-pushed
the
classifier/1inch
branch
from
66389a7
to
ae58ecb
Compare
come-maiz
force-pushed
the
classifier/1inch
branch
from
fb9f736
to
40e53be
Compare
come-maiz
force-pushed
the
classifier/1inch
branch
from
66b5cdd
to
b7d688a
Compare
|
@lukevs there was one merge problem, but now it's all good. I'm back again at my pool question. This transaction doesn't have a pool. Does it mean that it's not a swap? |
|
@ElOpio this is something we ran into w/ 0x as well. thinking we might want to rename that field to just contract_address |
|
pool and contract address, both sound good to me. But in this case there is no transfer to the contract, just a direct exchange. As far as I understand this function. |
No description provided.