Adds remote tdx provider for development #40
Conversation
| certFile := cCtx.String("tls-certificate") | ||
| keyFile := cCtx.String("tls-private-key") | ||
| certFile := cCtx.String("tls-certificate-path") | ||
| keyFile := cCtx.String("tls-private-key-path") |
There was a problem hiding this comment.
oh interesting, that's a separate bugfixe!
There was a problem hiding this comment.
could be it's own PR, seems important as main would be broken 🤔
cmd/proxy-client/main.go
Outdated
| var issuer atls.Issuer | ||
| if clientAttestationTypeFlag == "dummy" && devDummyDcapURL == "" { | ||
| return errors.New("dummy client attestation type but remote not specified") | ||
| } else if clientAttestationTypeFlag != "dummy" && devDummyDcapURL != "" { |
There was a problem hiding this comment.
upgrade string "dummy" to a const
cmd/proxy-client/main.go
Outdated
| return err | ||
| } | ||
| var issuer atls.Issuer | ||
| if clientAttestationTypeFlag == "dummy" && devDummyDcapURL == "" { |
There was a problem hiding this comment.
this if/else block feels error prone, and might be a nice one to structure in a more understandable and readable manner
one idea could be to create helper variables, like
isDummyAttestationType := clientAttestationTypeFlag == "dummy"
hasDummyDcapURL := devDummyDcapURL != ""
using that might feel awkward, but it'd make the code more legible
|
Looks great, directionally. Would be good to document the expected dummy dcap server response, and how to run one locally. |
|
should we merge this? I was expecting this in main already. Not that I need it at this point, my understanding was just that this is already live. |
3 participants
Allows configuring a remote quotes provider.