Skip to content

Conversation

harisvsulaiman
Copy link
Collaborator

@harisvsulaiman harisvsulaiman commented Dec 16, 2021

This allow the acl lib to be used with the current driver.
Mongodb atlas will auto-upgrade to mongodb 5.0 on February, I am hoping to get this merged before that.

Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>
@koresar koresar changed the base branch from master to new-mongodb-driver December 17, 2021 01:44
@koresar
Copy link

koresar commented Dec 17, 2021

Hello.
Thanks for the contribution mate!
Overall, the PR is good. Merging right now.
I have few minor questions though. I'll ask them separately.

Also, I've granted you Write access to this repo. :) Feel free to push directly to it.

@koresar
Copy link

koresar commented Dec 17, 2021

  1. Tests fail under node 10.
  2. This better be a SemVer MAJOR then.
  3. We should probably drop mongodb v3.6 and leave support for mongodb >= v4.
  4. Need to amend CI to test under node 16 as well.
  5. I'll also try it under both mongodb driver versions 3 and 4.

Future:

  1. Time to move to Promises interface.
  2. Time to add sessions (aka ACID transactions).

@koresar
Copy link

koresar commented Dec 17, 2021

Since the CI fails I'll force-merge it to a new branch and we'll go from there.

@koresar koresar merged commit bd3bbfe into flash-oss:new-mongodb-driver Dec 17, 2021
koresar added a commit that referenced this pull request Dec 17, 2021
* Update Mongodb to the new driver. (#6)

* update mongodb

Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>

* remove db.collection callback

Signed-off-by: Haris Sulaiman <harisvsulaiman@gmail.com>

* Drop node v10, add v16. Drop mongodb v3.6, add v5.0

* Try running CI tests for both mongodb v3 and v4

* Better arrangement of commands in CI steps

* Necessary README.md updates

Co-authored-by: Haris Sulaiman <haris@cloodot.com>
@koresar
Copy link

koresar commented Dec 17, 2021

Released as v3.0.0. Now supports both mongodb drivers v3 and v4.
https://github.com/flash-oss/node_acl/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants