Adds column stride parameters to ZOH_params struct #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the parameter structure to support column-wise memory layout by adding stride fields for both ZOH states and active mask data. Enables more flexible memory access patterns and improves compatibility with different tensor layouts.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds column-wise memory layout support by extending the ZOH_params struct with two new stride fields.
- Introduce
zoh_col_stridefor ZOH state column spacing - Introduce
active_mask_col_stridefor active-mask column spacing
Comments suppressed due to low confidence (2)
csrc/src/flash.h:59
- [nitpick] Consider adding or updating unit tests to cover the new column-stride behavior, verifying that both
zoh_col_strideandactive_mask_col_strideare correctly applied in memory layout routines.
index_t zoh_col_stride; // Stride between columns of ZOH states
csrc/src/flash.h:59
- The new fields
zoh_col_strideandactive_mask_col_stridemust be initialized (e.g., in a constructor or a default initializer) to prevent uninitialized memory access. Ensure all code paths set these strides to correct values.
index_t zoh_col_stride; // Stride between columns of ZOH states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the parameter structure to support column-wise memory layout by adding stride fields for both ZOH states and active mask data.
Enables more flexible memory access patterns and improves compatibility with different tensor layouts.