Add issue/PR templates #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces standardized issue and pull request templates to streamline bug reports, feature proposals, and performance diagnostics. Relaxes validation in variable-length attention forward by dropping dtype/device checks for mask and bias, enabling optional inputs and avoiding unnecessary failures.
github-actions
bot
requested review from
Evanwu1125,
SNHuan,
Thanksyy,
ftgreat,
juliohsu,
wubingheng111 and
zacliu2023
github-actions
bot
assigned
Evanwu1125,
ftgreat,
juliohsu,
SNHuan,
Thanksyy,
wubingheng111 and
zacliu2023
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces standardized issue and pull request templates to improve bug reporting, feature requests, and PR submissions for the Flash-DMA project. Additionally, it removes unused mask and bias device validation checks from the attention implementation.
- Adds comprehensive GitHub templates for different types of issues (bug reports, feature requests, performance issues) and PRs (bug fixes, feature support, performance optimizations)
- Removes unnecessary device validation checks for mask and bias parameters in the flash attention code
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/ISSUE_TEMPLATE/bug_report.yml | Bug report template with environment info and reproduction steps |
| .github/ISSUE_TEMPLATE/feature_request.yml | Feature request template with problem statement and implementation details |
| .github/ISSUE_TEMPLATE/performance_issue.yml | Performance issue template with benchmarking and profiling sections |
| .github/PULL_REQUEST_TEMPLATE/bug_fix.yml | Bug fix PR template with root cause analysis and testing requirements |
| .github/PULL_REQUEST_TEMPLATE/feature_support.yml | Feature PR template with design context and API changes |
| .github/PULL_REQUEST_TEMPLATE/performance_optimization.yml | Performance optimization PR template with benchmark evidence |
| csrc/flash_dmattn/flash_api.cpp | Removes device validation checks for mask and bias parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Document the optimisation, methodology, and results so reviewers can validate gains and correctness. |
There was a problem hiding this comment.
Corrected spelling of 'optimisation' to 'optimization' for American English consistency.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce standardized templates for issues and pull requests to enhance reporting and diagnostics.