Improve performance of data processing module #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves readability by adding spaces between parameters and using consistent naming conventions (Hq for query heads, Hkv for key-value heads). Ensures both forward and backward benchmark outputs use the same format for easier comparison and analysis.
…/flash-dmattn into optimize-sparse-logic
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the performance benchmarking module by standardizing configuration string formatting across forward and backward performance benchmarks. The changes enhance readability and consistency of benchmark output displays.
- Standardized configuration string format with consistent spacing and clearer parameter labels
- Unified causal/non-causal indicator format between forward and backward benchmarks
- Enhanced output readability for performance analysis
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| benchmarks/forward_performance.py | Updated configuration string format with clearer labels and consistent causal indicator |
| benchmarks/backward_performance.py | Aligned configuration string format to match forward benchmark style |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # Format configuration string | ||
| batch_size, num_heads, num_kv_heads, query_len, key_len, head_dim, keep_window_size, is_causal = config | ||
| config_str = f"B{batch_size}H{num_heads}K{num_kv_heads}Q{query_len}K{key_len}D{head_dim}W{keep_window_size}{'C' if is_causal else 'N'}" | ||
| config_str = f"B{batch_size} Hq{num_heads} Hkv{num_kv_heads} Q{query_len} K{key_len} D{head_dim} W{keep_window_size} {'C' if is_causal else 'N'}" |
There was a problem hiding this comment.
The parameter label 'K' is used twice in the configuration string - once for num_kv_heads and once for key_len. This creates ambiguity in the output. Consider using 'Kl' for key_len to differentiate it from the 'Hkv' label for num_kv_heads.
Suggested change
| config_str = f"B{batch_size} Hq{num_heads} Hkv{num_kv_heads} Q{query_len} K{key_len} D{head_dim} W{keep_window_size} {'C' if is_causal else 'N'}" | |
| config_str = f"B{batch_size} Hq{num_heads} Hkv{num_kv_heads} Q{query_len} Kl{key_len} D{head_dim} W{keep_window_size} {'C' if is_causal else 'N'}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the data processing module to enhance performance and reduce execution time during data handling operations.