Remove unused CUDA generator includes for improved build performance #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up unnecessary ATen CUDA generator imports that are no longer referenced in the codebase. Reduces compilation dependencies and improves build performance.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Removes unused CUDA generator includes from flash attention implementation to reduce compilation dependencies and improve build performance. The changes eliminate ATen CUDA generator imports that are not being utilized in the codebase.
- Removes
ATen/cuda/CUDAGeneratorImpl.hinclude from both header and implementation files - Removes
ATen/cuda/detail/UnpackRaw.cuhinclude from the implementation file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csrc/src/flash.h | Removes unused CUDAGeneratorImpl include from header file |
| csrc/flash_api.cpp | Removes unused CUDA generator includes from implementation file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate unnecessary ATen CUDA generator imports to reduce compilation dependencies and enhance build efficiency.