Eager load tags relation in discussion, posts and flags listing endpoints #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2021
Merged
askvortsov1
approved these changes
Mar 22, 2021
tankerkiller125
approved these changes
Mar 22, 2021
askvortsov1
pushed a commit
that referenced
this pull request
Mar 11, 2022
…ints (#125) * Eager load tags relation when listing posts & discussions * Eager load ListFlags post.discussion.tags relation
askvortsov1
pushed a commit
that referenced
this pull request
May 10, 2022
…ints (#125) * Eager load tags relation when listing posts & discussions * Eager load ListFlags post.discussion.tags relation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flarum/framework#2637
Works with flarum/framework#2724
When discussions are loaded, the
tagsrelationship is always needed, because the DiscussionPolicy accesses said relation.The key difference to note here between including relationships and eager loading them, is that just because we eager load it doesn't mean it will be included in the JSON response, the response always included relationships explicitly included in the request.