Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Eagerload lastPostedDiscussion needed relationships #120

Merged
merged 1 commit into from
Mar 6, 2021
Merged

[Performance] Eagerload lastPostedDiscussion needed relationships #120

merged 1 commit into from
Mar 6, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Feb 24, 2021 •
edited
Loading

@SychO9 SychO9 requested a review from luceos February 24, 2021 18:46
@SychO9 SychO9 mentioned this pull request Feb 25, 2021
Closed
13 tasks
@luceos
Copy link
Member

luceos commented Mar 6, 2021

Understand that we can only eager load the state relation if stateFor was called ahead of that. I'm glad it was, so approving.

@askvortsov1 askvortsov1 merged commit f85cc59 into master Mar 6, 2021
@SychO9 SychO9 deleted the sm/2177-tags-performance branch March 6, 2021 15:54
askvortsov1 pushed a commit that referenced this pull request Mar 11, 2022
@SychO9
Eagerload lastPostedDiscussion needed relationships (#120)
79e28f0
askvortsov1 pushed a commit that referenced this pull request May 10, 2022
@SychO9
Eagerload lastPostedDiscussion needed relationships (#120)
439755b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos luceos approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @luceos @askvortsov1