Skip to content

Conversation

@DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Nov 11, 2025

2.x equivalent to #4277

Fixes #4276

Changes proposed in this pull request:
Early return if minimum number of primary and secondary tags is 0. Deferring it rather then force allowing in that case allows other policies to take action

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review November 11, 2025 07:58
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner November 11, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.x & 2.x] Global canStartDiscussion forum attribute returns true in unexpected cases

1 participant