Skip to content

Conversation

@DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Nov 8, 2025

Fixes #0000
Accidentally hitting the delete button for removing a scope

Changes proposed in this pull request:
Minor Quality of Life Improvement for Community Managers / Admins. Opens a Confirmation Box before a permission scope is deleted.

From past experiences "deleting" that scope doesn't actually irreversibly delete the configured permissions — unclear if this is intended behaviour or a bug. But erring on the side of caution I still choose a terminology which still somewhat suggests that the action is destructive

Reviewers should focus on:

Screenshot
Screenshot 2025-11-09 at 00 07 57

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

Minor Quality of Life Improvement for Community Managers / Admins. Opens a Confirmation Box before a permission scope is deleted.

From past experiences "deleting" that scope doesn't actually irreversibly delete the configured permissions — unclear if this is intended behaviour or a bug. But erring on the side of caution I still choose a terminology which suggests that the action is destructive
@DavideIadeluca DavideIadeluca marked this pull request as ready for review November 8, 2025 23:20
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner November 8, 2025 23:21
@imorland imorland changed the title chore(core): open confirm box before deleting permission scope [2.x] chore(core): open confirm box before deleting permission scope Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant