[2.x] chore(core): open confirm box before deleting permission scope #4272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Accidentally hitting the delete button for removing a scope
Changes proposed in this pull request:
Minor Quality of Life Improvement for Community Managers / Admins. Opens a Confirmation Box before a permission scope is deleted.
From past experiences "deleting" that scope doesn't actually irreversibly delete the configured permissions — unclear if this is intended behaviour or a bug. But erring on the side of caution I still choose a terminology which still somewhat suggests that the action is destructive
Reviewers should focus on:
Screenshot

Necessity
Confirmed
composer test).Required changes: