Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] fix: resolve regression in TS typing errors #4097

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

DavideIadeluca
Copy link
Contributor

Resolves regression introduced in #4027

Fixes #0000
If a shims.d.ts declaration file doesn't include any import statement, the TS compiler will treat it as an ambient declaration — a type-only interface with no associated value at runtime — which causes regression in other parts of the codebase (notably extend.ts).

Changes proposed in this pull request:

  • Add dummy imports to shims to work around TypeScript's module augmentation mechanism.

Reviewers should focus on:

  • For consistency reasons, I always included all module declaration imports, even if only one or no additional were required.

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review October 26, 2024 18:21
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner October 26, 2024 18:21
@imorland imorland merged commit 391a861 into flarum:1.x Oct 26, 2024
274 checks passed
@imorland imorland deleted the di/typing-regression branch October 26, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants