New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1.x): textformatter `2.15` has breaking changes #3946

Merged

SychO9 merged 1 commit into 1.x from sm/s9e-constraint

Dec 14, 2023

Member

SychO9 commented Dec 14, 2023 •

edited

Loading

Changes proposed in this pull request:
The recent 2.15 textformatter release seems to have some breaking changes:

Best to prevent updates to it for now until further notice for the 1.x line

Necessity

Has the problem that is being solved here been clearly explained?
If applicable, have various options for solving this problem been considered?
For core PRs, does this need to be in core, or could it be in an extension?
Are we willing to maintain this for years / potentially forever?

Confirmed

Frontend changes: tested on a local Flarum installation.
Backend changes: tests are green (run composer test).
Core developer confirmed locally this works as intended.
Tests have been added, or are not appropriate here.


          fix(1.x): textformatter 2.15 has breaking changes

2109e36

SychO9 requested a review from a team as a code owner

December 14, 2023 13:38

SychO9 changed the title ~~fix(1.x): textformatter 2.15 has breaking changes~~ fix(1.x): textformatter 2.15 has breaking changes

imorland approved these changes

View reviewed changes

SychO9 merged commit 6208030 into 1.x

313 checks passed

SychO9 deleted the sm/s9e-constraint branch

December 14, 2023 13:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet