Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification subject discussion eager loading fails #3788

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 15, 2023

Closes #3778

Changes proposed in this pull request:
In 1.7 the property_exists check was added to fix PHP 8.2 deprecations but missed the fact that dynamic properties cannot be checked like that.

I don't believe this is the problem described in the issue however, only 10 notifications are loaded at a time. So it could be a bad extension.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner April 15, 2023 12:39
@SychO9 SychO9 added this to the 1.8 milestone Apr 15, 2023
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 merged commit 7a6d477 into main Apr 16, 2023
@SychO9 SychO9 deleted the sm/3778-notifications-perf branch April 16, 2023 20:12
@github-actions github-actions bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fttb slow response time
2 participants