Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(seo): Use h2 header for discussions on discussions list #3731

Merged
merged 3 commits into from
Feb 15, 2023
Merged

feat(seo): Use h2 header for discussions on discussions list #3731

merged 3 commits into from
Feb 15, 2023

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Feb 11, 2023

Changes proposed in this pull request:

Continuation of #3724 - since tag/mainpage header changed from h2 to h1, next header should be h2. See #3724 (comment)

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@rob006 rob006 requested a review from a team as a code owner February 11, 2023 20:30
@SychO9 SychO9 added this to the 1.7 milestone Feb 15, 2023
@SychO9 SychO9 added the javascript Pull requests that update Javascript code label Feb 15, 2023
@SychO9 SychO9 merged commit 37fd218 into flarum:main Feb 15, 2023
@rob006 rob006 deleted the seo-headings-part-2 branch February 15, 2023 16:51
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos luceos approved these changes

@SychO9 SychO9 SychO9 approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code type/seo
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@rob006 @luceos @SychO9