Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sticky): list discussions works as expected with stickies #3507

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jul 7, 2022

Part of #3508

Changes proposed in this pull request:
Adds integration tests for the sticky extension behavior. Useful for future changes so that we make sure to retain the current wanted behavior.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9 SychO9 added this to the 1.4 milestone Jul 8, 2022
@SychO9 SychO9 merged commit 2e840dc into main Jul 8, 2022
@SychO9 SychO9 deleted the sm/sticky-backend-tests branch July 8, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants