Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown show results search button hidden while loading results #3431

Merged
merged 1 commit into from
May 20, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 20, 2022

Fixes #3400

Changes proposed in this pull request:
The link to more results resides in the DiscussionSearchSource component. Search source components are currently only rendered when all of them have finished loading results, hence why the relevant link disappears. That is unnecessary and we can directly render them, I believe this used to be the previous behavior as well.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 merged commit a79e2c2 into main May 20, 2022
@SychO9 SychO9 deleted the sm/3400-always-show-search-results-button branch May 20, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Search all discussion for" button disappears
3 participants