Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error in funding composer.json block bricks frontend #3239

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

Any error in composer.json's funding block syntax will brick the admin frontend.

Oddly, this error seems to persist after correcting the error, composer update and a cache clear on my local dev forum. I had to implement this to allow me to toggle the extension, which then fixed the error.

Reviewers should focus on:

N/A

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat self-assigned this Dec 29, 2021
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, could we use something like Arr::get($funding, '0.url')?

@davwheat davwheat force-pushed the dw/fix-json-error-brick-admin-fe branch from 1c0fc60 to b5aa8f1 Compare December 29, 2021 01:21
[ci skip] [skip ci]
@davwheat
Copy link
Member Author

That was a fair bit simpler.

@davwheat davwheat merged commit 8fac735 into master Dec 29, 2021
@davwheat davwheat deleted the dw/fix-json-error-brick-admin-fe branch December 29, 2021 02:25
@askvortsov1 askvortsov1 added this to the 1.2 milestone Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants