-
-
Notifications
You must be signed in to change notification settings - Fork 860
1.2 JS clean-up #3214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.2 JS clean-up #3214
Conversation
| content() { | ||
| return []; | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should really all become abstract methods for v2
askvortsov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as long as the last few NestedStringArray are changed to Mithril.Children
dsevillamartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested locally (shouldn't need to) & changes are mostly docblocks which don't break anything. Nothing stands out to me so LGTM.
Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>
a64b326 to
bd41f76
Compare
Changes proposed in this pull request:
Performs some clean-up to frontend JS, ready for 1.2.
extend.tstyping issue introduced in Convert extend util to TypeScript #2928window.requestAnimationFrame()-- this is supported in all browsers nownullinstead of''or[]for empty vdomsPost,PostsUserPageandslideable(40be94d)Reviewers should focus on:
N/A
Necessity
Confirmed
composer test).