Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add a11y labels to auth modal inputs #3207

Merged
merged 1 commit into from
Dec 16, 2021
Merged

fix: Add a11y labels to auth modal inputs #3207

merged 1 commit into from
Dec 16, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Dec 15, 2021 •
edited
Loading

Part of #3360

Changes proposed in this pull request:
Adds aria labels to auth modal inputs which only have placeholders.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Dec 15, 2021
@SychO9 SychO9 merged commit a36f98d into master Dec 16, 2021
@SychO9 SychO9 deleted the sm/auth-forms-a11y branch December 16, 2021 08:30
@SychO9 SychO9 added this to the 1.2 milestone Dec 16, 2021
@davwheat davwheat mentioned this pull request Mar 28, 2022
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @davwheat @askvortsov1